Update subscriptions view to display video publish time in relative form even fetched via RSS #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
PR: dependencies
… form even fetched via RSS
PikachuEXE
force-pushed
the
feature/rss-feed-relative-time
branch
from
d07a1e3 to
882441d
Compare
absidue
reviewed
Feb 25, 2023
Comment on lines
430
to
441
| let timeDiffFromNow = ((now - this.data.publishedDate) / 1000) / 60 | ||
| let timeUnit = 'minute' | ||
|
|
||
| if (timeDiffFromNow > 60) { | ||
| timeDiffFromNow /= 60 | ||
| timeUnit = 'hour' | ||
| } | ||
|
|
||
| if (timeUnit === 'hour' && timeDiffFromNow > 24) { | ||
| timeDiffFromNow /= 24 | ||
| timeUnit = 'day' | ||
| } |
There was a problem hiding this comment.
Could you please add support for seconds (it's rare but happens) as well as months and years?
I'm subscribed to one channel that hasn't uploaded in 3 years but i'm subscribed to keep it easily accessible.
PikachuEXE
removed
the
PR: dependencies
Also add more code comments Also fix issue of display after switching back from another view
|
Seconds (hardcode time diff to 37 seconds) Month: Year: |
absidue
approved these changes
Feb 26, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 26, 2023
ChunkyProgrammer
approved these changes
Feb 27, 2023
github-actions
bot
removed
the
PR: waiting for review
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update subscriptions view to display video publish time in relative form even fetched via RSS
Pull Request Type
Related issue
N/A
Description
Currently subscriptions view displays video publish times in absolute form when
Fetch Feeds from RSSenabledThis PR updated it to display time in relative form like when it's disabled
Screenshots
Testing
Fetch Feeds from RSSDesktop
Additional context